/
redundant_line_break.rb
161 lines (134 loc) · 5.06 KB
/
redundant_line_break.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
# frozen_string_literal: true
module RuboCop
module Cop
module Layout
# Checks whether certain expressions, e.g. method calls, that could fit
# completely on a single line, are broken up into multiple lines unnecessarily.
#
# @example any configuration
# # bad
# foo(
# a,
# b
# )
#
# puts 'string that fits on ' \
# 'a single line'
#
# things
# .select { |thing| thing.cond? }
# .join('-')
#
# # good
# foo(a, b)
#
# puts 'string that fits on a single line'
#
# things.select { |thing| thing.cond? }.join('-')
#
# @example InspectBlocks: false (default)
# # good
# foo(a) do |x|
# puts x
# end
#
# @example InspectBlocks: true
# # bad
# foo(a) do |x|
# puts x
# end
#
# # good
# foo(a) { |x| puts x }
#
class RedundantLineBreak < Base
include CheckAssignment
extend AutoCorrector
MSG = 'Redundant line break detected.'
def on_lvasgn(node)
super unless end_with_percent_blank_string?(processed_source)
end
def on_send(node)
# Include "the whole expression".
node = node.parent while node.parent&.send_type? ||
convertible_block?(node) ||
node.parent.is_a?(RuboCop::AST::BinaryOperatorNode)
return unless offense?(node) && !part_of_ignored_node?(node)
register_offense(node)
end
alias on_csend on_send
private
def end_with_percent_blank_string?(processed_source)
processed_source.buffer.source.end_with?("%\n\n")
end
def check_assignment(node, _rhs)
return unless offense?(node)
register_offense(node)
end
def register_offense(node)
add_offense(node) do |corrector|
corrector.replace(node, to_single_line(node.source).strip)
end
ignore_node(node)
end
def offense?(node)
return false if !node.multiline? || too_long?(node) || !suitable_as_single_line?(node)
return require_backslash?(node) if node.and_type? || node.or_type?
!index_access_call_chained?(node) && !configured_to_not_be_inspected?(node)
end
def require_backslash?(node)
processed_source.lines[node.loc.operator.line - 1].end_with?('\\')
end
def index_access_call_chained?(node)
return false unless node.send_type? && node.method?(:[])
node.children.first.send_type? && node.children.first.method?(:[])
end
def configured_to_not_be_inspected?(node)
return true if other_cop_takes_precedence?(node)
!cop_config['InspectBlocks'] && (node.block_type? ||
any_descendant?(node, :block, &:multiline?))
end
def other_cop_takes_precedence?(node)
single_line_block_chain_enabled? && any_descendant?(node, :block) do |block_node|
block_node.parent.send_type? && block_node.parent.loc.dot && !block_node.multiline?
end
end
def single_line_block_chain_enabled?
@config.for_cop('Layout/SingleLineBlockChain')['Enabled']
end
def suitable_as_single_line?(node)
!comment_within?(node) &&
node.each_descendant(:if, :case, :kwbegin, :def, :defs).none? &&
node.each_descendant(:dstr, :str).none? { |n| n.heredoc? || n.value.include?("\n") } &&
node.each_descendant(:begin, :sym).none? { |b| !b.single_line? }
end
def convertible_block?(node)
parent = node.parent
parent&.block_type? && node == parent.send_node &&
(node.parenthesized? || !node.arguments?)
end
def comment_within?(node)
comment_line_numbers = processed_source.comments.map { |comment| comment.loc.line }
comment_line_numbers.any? do |comment_line_number|
comment_line_number >= node.first_line && comment_line_number <= node.last_line
end
end
def too_long?(node)
lines = processed_source.lines[(node.first_line - 1)...node.last_line]
to_single_line(lines.join("\n")).length > max_line_length
end
def to_single_line(source)
source
.gsub(/" *\\\n\s*'/, %q(" + ')) # Double quote, backslash, and then single quote
.gsub(/' *\\\n\s*"/, %q(' + ")) # Single quote, backslash, and then double quote
.gsub(/(["']) *\\\n\s*\1/, '') # Double or single quote, backslash, then same quote
.gsub(/\n\s*(?=(&)?\.\w)/, '') # Extra space within method chaining which includes `&.`
.gsub(/\s*\\?\n\s*/, ' ') # Any other line break, with or without backslash
end
def max_line_length
config.for_cop('Layout/LineLength')['Max']
end
end
end
end
end