/
multiline_when_then.rb
64 lines (56 loc) · 1.48 KB
/
multiline_when_then.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# Checks uses of the `then` keyword
# in multi-line when statements.
#
# @example
# # bad
# case foo
# when bar then
# end
#
# # good
# case foo
# when bar
# end
#
# # good
# case foo
# when bar then do_something
# end
#
# # good
# case foo
# when bar then do_something(arg1,
# arg2)
# end
#
class MultilineWhenThen < Base
include RangeHelp
extend AutoCorrector
MSG = 'Do not use `then` for multiline `when` statement.'
def on_when(node)
return if !node.then? || require_then?(node)
range = node.loc.begin
add_offense(range) do |corrector|
corrector.remove(range_with_surrounding_space(range, side: :left, newlines: false))
end
end
private
# Requires `then` for write `when` and its body on the same line.
def require_then?(when_node)
unless when_node.conditions.first.first_line == when_node.conditions.last.last_line
return true
end
return false unless when_node.body
same_line?(when_node, when_node.body)
end
def accept_node_type?(node)
node&.array_type? || node&.hash_type?
end
end
end
end
end