New cop EndBlock

CHANGELOG.md

@@ -27,6 +27,7 @@
 * New cop `EndInMethod` tracks uses of `END` in method definitions.
 * New cop `LiteralInCondition` tracks uses of literals in the conditions of `if/while/until`.
 * New cop `BeginBlock` tracks uses of `BEGIN` blocks.
+* New cop `EndBlock` tracks uses of `END` blocks.
 * Add support for auto-correction of some offences with `-a`/`--auto-correct`.
 
 ### Changes

config/enabled.yml

@@ -348,6 +348,10 @@ CharacterLiteral:
 BeginBlock:
   Enabled: true
 
+# Avoid the use of END blocks.
+EndBlock:
+  Enabled: true
+
 ## Warnings
 
 # Don't use assignment in conditions.

lib/rubocop.rb

@@ -53,6 +53,7 @@
 require 'rubocop/cop/style/empty_lines'
 require 'rubocop/cop/style/empty_literal'
 require 'rubocop/cop/style/encoding'
+require 'rubocop/cop/style/end_block'
 require 'rubocop/cop/style/end_of_line'
 require 'rubocop/cop/style/favor_join'
 require 'rubocop/cop/style/favor_modifier'

lib/rubocop/cop/style/end_block.rb

@@ -0,0 +1,18 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    module Style
+      # This cop checks for BEGIN blocks.
+      class EndBlock < Cop
+        MSG = 'Avoid the use of END blocks. Use `Kernel#at_exit` instead.'
+
+        def on_postexe(node)
+          add_offence(:convention, node.loc.expression, MSG)
+
+          super
+        end
+      end
+    end
+  end
+end

spec/rubocop/cops/style/end_block_spec.rb

@@ -0,0 +1,19 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe EndBlock do
+        let(:cop) { EndBlock.new }
+
+        it 'reports an offence for an END block' do
+          src = ['END { test }']
+          inspect_source(cop, src)
+          expect(cop.offences.size).to eq(1)
+        end
+      end
+    end
+  end
+end