Mark Style/IfWithBooleanLiteralBranche as unsafe auto-correction

Follow #9461 (comment). This PR marks `Style/IfWithBooleanLiteralBranche` as unsafe auto-correction.
rubocop · Jan 31, 2021 · 5870d6d · 5870d6d
1 parent 3e26be1
commit 5870d6d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/changelog/change_mark_unsafe_autocorrect_for_if_with_boolean_literal_branches.md b/changelog/change_mark_unsafe_autocorrect_for_if_with_boolean_literal_branches.md
@@ -0,0 +1 @@
+* [#9476](https://github.com/rubocop-hq/rubocop/pull/9476): Mark `Style/IfWithBooleanLiteralBranche` as unsafe auto-correction. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -3521,6 +3521,7 @@ Style/IfWithBooleanLiteralBranches:
   Description: 'Checks for redundant `if` with boolean literal branches.'
   Enabled: pending
   VersionAdded: '1.9'
+  SafeAutoCorrect: false
   AllowedMethods:
     - nonzero?
 

diff --git a/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb b/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb
@@ -6,6 +6,8 @@ module Style
       # This cop checks for redundant `if` with boolean literal branches.
       # It checks only conditions to return boolean value (`true` or `false`) for safe detection.
       # The conditions to be checked are comparison methods, predicate methods, and double negative.
+      # However, auto-correction is unsafe because there is no guarantee that all predicate methods
+      # will return boolean value. Those methods can be allowed with `AllowedMethods` config.
       #
       # @example
       #   # bad