Inline and remove inspect_source_file

rubocop · Dec 24, 2020 · d160595 · d160595
1 parent f57312a
commit d160595
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/lib/rubocop/rspec/cop_helper.rb b/lib/rubocop/rspec/cop_helper.rb
@@ -9,10 +9,6 @@ module CopHelper
   let(:ruby_version) { 2.4 }
   let(:rails_version) { false }
 
-  def inspect_source_file(source)
-    Tempfile.open('tmp') { |f| inspect_source(source, f) }
-  end
-
   def inspect_source(source, file = nil)
     RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
     RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}

diff --git a/spec/rubocop/cop/layout/end_of_line_spec.rb b/spec/rubocop/cop/layout/end_of_line_spec.rb
@@ -14,11 +14,19 @@
       # be moved somewhere more general ?
       # Also working with encodings is actually the responsibility of
       # 'whitequark/parser' gem, not Rubocop itself so these test really belongs there(?)
-      offenses = inspect_source_file(<<~RUBY)
+
+      encoding = 'iso-8859-15'
+      input = (+<<~RUBY).force_encoding(encoding)
         # coding: ISO-8859-15#{eol}
         # Euro symbol: \xa4#{eol}
       RUBY
-      expect(offenses.size).to eq(1)
+
+      expect do
+        Tempfile.open('tmp', encoding: encoding) { |f| expect_no_offenses(input, f) }
+      end.to raise_error(
+        RSpec::Expectations::ExpectationNotMetError,
+        /Carriage return character (detected|missing)./
+      )
     end
   end