Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The error message from Bundler/OrderedGems should state that its intention is alphabetization #3753

Closed
jaredbeck opened this issue Nov 30, 2016 · 0 comments
Closed

The error message from Bundler/OrderedGems should state that its intention is alphabetization #3753

jaredbeck opened this issue Nov 30, 2016 · 0 comments

Comments

@jaredbeck
Copy link
Contributor

With a minor change to the current message, the purpose of OrderedGems could be made clear.

Current Message

Gem vcr should appear before webmock in their gem group.

Suggested Message

Alphabetize gems: Gem vcr should appear before webmock in their gem group.

RuboCop version

0.46.0 (using Parser 2.3.3.0, running on ruby 2.2.5 x86_64-darwin15)
@tejasbubane tejasbubane mentioned this issue Nov 30, 2016
Merged
11 tasks
tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Dec 18, 2016
@tejasbubane
[Fixes rubocop#3753] Change error message of Bundler/OrderedGems
e6e7945 
To mention `Alphabetize Gems`.

Original error message:
```
Gem `rspec` should appear before `rubocop` in their gem group.
```

New error message:
```
Gems should be sorted in an alphabetical order within their section of
the Gemfile. Gem `x` should appear before `y`.
```
bbatsov pushed a commit that referenced this issue Dec 19, 2016
@tejasbubane @bbatsov
[Fix #3753] Improve the offense message of Bundler/OrderedGems (#3756)
ccf4919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredbeck