Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: curly brace converting to do WITHOUT SPACE breaks code block (changes field_set_tag { to field_set_tagdo) #7534

Closed
jeremymoritz opened this issue Nov 28, 2019 · 0 comments · Fixed by #7535
Closed

Bug: curly brace converting to do WITHOUT SPACE breaks code block (changes field_set_tag { to field_set_tagdo) #7534

jeremymoritz opened this issue Nov 28, 2019 · 0 comments · Fixed by #7535
Labels
bug

Comments

@jeremymoritz
Copy link

When rubocop.yml is configured thusly:

Layout/SpaceBeforeBlockBraces:
  EnforcedStyle: no_space

then this bug happens

field_set_tag {

gets changed to

field_set_tagdo

image

This breaks the code
@koic koic added the bug label Nov 28, 2019
@koic koic mentioned this issue Nov 28, 2019
Merged
8 tasks
koic added a commit to koic/rubocop that referenced this issue Nov 29, 2019
@koic
[Fix rubocop#7534] Fix an incorrect autocorrect for `Layout/SpaceBefo…
e61357e 
…reBlockBraces`

Fixes rubocop#7534.

Fix an incorrect autocorrect for `Style/BlockDelimiters` cop and
`Layout/SpaceBeforeBlockBraces` cop with `EnforcedStyle: no_space`
when using multiline braces.
koic added a commit that referenced this issue Nov 29, 2019
@koic
Merge pull request #7535 from koic/fix_an_incorrect_autocorrect_for_s…
b281caf 
…pace_before_block_braces

[Fix #7534] Fix an incorrect autocorrect for `Layout/SpaceBeforeBlockBraces`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7534] Fix an incorrect autocorrect for Layout/SpaceBeforeBlockBraces koic/rubocop
2 participants
@koic @jeremymoritz