Register an offense for RedundantMerge inside each_with_object #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
each_with_object_redundant_merge
branch
2 times, most recently
from
65bfe12
to
b983998
Compare
| end | ||
|
|
||
| it 'autocorrects when the receiver is the object being built when ' \ | ||
| 'merge! is not the last statement' do |
There was a problem hiding this comment.
But is is the last statement (of the block) here.
There was a problem hiding this comment.
Whoops, copy paste mistake.
There was a problem hiding this comment.
The name of the test has been updated.
rrosenblum
force-pushed
the
each_with_object_redundant_merge
branch
2 times, most recently
from
fa35bd8
to
cfba31c
Compare
| next if node.value_used? | ||
| if node.value_used? | ||
| parent = node.parent | ||
| grand_parent = parent.parent if parent.begin_type? |
There was a problem hiding this comment.
Isn't grandparent a single word in english?
rrosenblum
force-pushed
the
each_with_object_redundant_merge
branch
from
cfba31c
to
8337e5d
Compare
rrosenblum
force-pushed
the
each_with_object_redundant_merge
branch
from
8337e5d
to
7d89757
Compare
bbatsov
added a commit
that referenced
this pull request
Mar 22, 2016
…erge Register an offense for RedundantMerge inside each_with_object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the benefit of
each_with_objectis using mutable objects.value_used?isn't actual accurate in this condition.What do you think about accounting for this inside of
value_used?instead of only inRedundantMerge?