Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VersionChanged for Rails/SkipsModelValidations #6419

Conversation

koic
Copy link
Member

@koic koic commented Oct 29, 2018

Follow up of #6392.

#6392 has been changed in RuboCop 0.60. (The next version of 0.59.2 is not 0.59.3.)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up of rubocop#6392.

rubocop#6392 has been changed in RuboCop 0.60. (The next version of 0.59.2 is not 0.59.3.)
@koic
Copy link
Member Author

koic commented Oct 29, 2018

I have a question at this PR and wrote it to #5976 (comment).

@bbatsov bbatsov merged commit 34fea10 into rubocop:master Nov 3, 2018
@koic koic deleted the update_version_changed_for_skips_model_validations branch November 6, 2018 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants