Exclude gemspec file by default for Metrics/BlockLength
#6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
commented
Mar 5, 2019
| @@ -1643,13 +1643,15 @@ Metrics/BlockLength: | |||
| Description: 'Avoid long blocks with many lines.' | |||
| Enabled: true | |||
| VersionAdded: '0.44' | |||
| VersionChanged: '0.58' | |||
| VersionChanged: '0.66' | |||
There was a problem hiding this comment.
📝 I change VersionChanged to change the default setting. I think that the next release when merging this will be 0.66.0.
koic
force-pushed
the
exclude_gemspec_by_default_for_metrics_block_length
branch
from
1b7a6f1
to
731826a
Compare
This PR excludes gemspec file by default for `Metrics/BlockLength` cop.
When gemspec file is changed, it is mainly the increase / decrease for
`add_runtime_dependency` and `add_development_dependency`.
There is no tendency to change with complicated logic.
Also gemspec file made with `bundle gem` is also warned by default.
```console
% bundle -v
Bundler version 2.0.1
% bundle gem foo
Creating gem 'foo'...
MIT License enabled in config
create foo/Gemfile
create foo/lib/foo.rb
create foo/lib/foo/version.rb
create foo/foo.gemspec
create foo/Rakefile
create foo/README.md
create foo/bin/console
create foo/bin/setup
create foo/.gitignore
create foo/.travis.yml
create foo/.rspec
create foo/spec/spec_helper.rb
create foo/spec/foo_spec.rb
create foo/LICENSE.txt
Initializing git repo in /private/tmp/foo
% rubocop -v
0.65.0
% rubocop --only Metrics/BlockLength
Inspecting 8 files
C.......
Offenses:
foo.gemspec:6:1: C: Metrics/BlockLength: Block has too many
lines. [26/25]
Gem::Specification.new do |spec| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8 files inspected, 1 offense detected
```
Therefore this PR excluded gemspec file by default.
koic
force-pushed
the
exclude_gemspec_by_default_for_metrics_block_length
branch
from
731826a
to
ac4c7bc
Compare
rrosenblum
approved these changes
Mar 5, 2019
|
🙇 |
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Jul 18, 2019
And apply `bundle exec rubocop --auto_gen_config`. rubocop/rubocop#6810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes gemspec file by default for
Metrics/BlockLengthcop.When gemspec file is changed, it is mainly the increase / decrease for
add_runtime_dependencyandadd_development_dependency.There is no tendency to change with complicated logic.
Also gemspec file made with
bundle gemis also warned by default.Therefore this PR excluded gemspec file by default.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.