Fix false negative for Rails/LinkToBlank when _blank is a symbol #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intrepidd
force-pushed
the
link-to-blank-sym-fix
branch
2 times, most recently
from
d9351f8
to
7b26e6a
Compare
koic
reviewed
Mar 7, 2019
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#6821](https://github.com/rubocop-hq/rubocop/pull/6821): Fix false positive for Rails/LinkToBlank when _blank is a symbol. ([@Intrepidd][]) | |||
There was a problem hiding this comment.
What is not able to find a problem is "false negative" (not "false positive") :-)
There was a problem hiding this comment.
Ok I thought as a false positive as in "your code is ok" when it is not.
I'll update my PR right away
Thanks !
Intrepidd
force-pushed
the
link-to-blank-sym-fix
branch
from
7b26e6a
to
f27d79f
Compare
Intrepidd
changed the title
koic
reviewed
Mar 7, 2019
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#6821](https://github.com/rubocop-hq/rubocop/pull/6821): Fix false negative for Rails/LinkToBlank when _blank is a symbol. ([@Intrepidd][]) | |||
There was a problem hiding this comment.
This is a nitpick. It seems that _ intents italic start if _blank is not enclosed in backticks.
-* [#6821](https://github.com/rubocop-hq/rubocop/pull/6821): Fix false negative for Rails/LinkToBlank when _blank is a symbol. ([@Intrepidd][])
+* [#6821](https://github.com/rubocop-hq/rubocop/pull/6821): Fix false negative for Rails/LinkToBlank when `_blank` is a symbol. ([@Intrepidd][])
Intrepidd
force-pushed
the
link-to-blank-sym-fix
branch
from
f27d79f
to
53597d0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using
target: :_blank, theRails/LinkToBlankcop does not register an offence when it should.