Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rake task to release to rubygems and github #7803

Closed
wants to merge 1 commit into from
Closed

Add rake task to release to rubygems and github #7803

wants to merge 1 commit into from

Conversation

ShockwaveNN
Copy link
Contributor

@ShockwaveNN ShockwaveNN commented Mar 17, 2020

I think it's never hurt to release this gem not only to rubygems.org, but also on GitHub packages

I'm not sure of exact of release process (didn't find any info), but I think rake task rake release is used.
If so - I created new task release_github_rubygems which first call rake release and after push resulting gem to Github packages.

Please not, that person, who perform releases should execute

echo ":github: Bearer GH_TOKEN" >> ~/.gem/credentials

before pushing gem. GH_TOKEN can be generated here


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 18, 2020

I'd probably add a separate task to release to GitHub, plus some notes on using it, apart from the combined one. Then, again - I release using rake release, so I'm not sure I'll remember to run a new rake task going forward. :D

@ShockwaveNN
Copy link
Contributor Author

I'd probably add a separate task to release to GitHub, plus some notes on using it, apart from the combined one.

Agree, will do

Then, again - I release using rake release, so I'm not sure I'll remember to run a new rake task going forward. :D

I think I can add releasing to github in default rake release task, but I don't think this is a good idea

@koic
Copy link
Member

koic commented Mar 18, 2020

Is this a required release method for RuboCop only? Otherwise, for example, you can propose a command to RubyGems.

And users can confirm a released gem impact by numbers such as the number of downloads on rubygem.org. I'm curious about the advantages of adding publishing using a non-central hosted GitHub package :-)

@ShockwaveNN
Copy link
Contributor Author

@koic Sorry, I'm not fully understand that you trying to say

I'm curious about the advantages of adding publishing using a non-central hosted GitHub package

I don't know about any REAL advantages, I was just interested to try it in my projects and I thought this may be good for my favorite open-source project, but if rubocop dev team see no advantage in this - I think we can just cancel that idea

@koic
Copy link
Member

koic commented Mar 18, 2020

Thank you for replying. I'm also interested in the new GitHub Packages feature :-)

IMHO, For private internal hosting gems, using GitHub packages is convenient because hosting using gem server is not necessary. OTOH, for published available gems, it's better to release only to the centrally hosted rubygems.org. It would be simpler to focus on just one.

@ShockwaveNN
Copy link
Contributor Author

It would be simpler to focus on just one.

So, to be clear - better close this PR?

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 19, 2020

Yeah, let's close it. Thanks for the suggestion, though!

@bbatsov bbatsov closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants