New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #7979] Add runtime dependency for did_you_mean #7980
Conversation
6e223a8
to
1d220b3
Compare
1d220b3
to
79312f9
Compare
I don't think that should needed for a gem bundled with Ruby. It also seems that most people didn't run into such an issue. @koic Any idea what might be causing such a problem? |
@bbatsov, I noticed yesterday that according to the docs out should be included with Ruby 2.3+. Looks like at least one other person came across this in #7979. Also in my case, I saw this issue in CI not my local machine so I'm trying to gather more information on that environment. |
RuboCop Rails had a similar problem, but hasn't got a solution to it yet. AFAIK, Ruby has enable and disable options for did_you_mean. % ruby -v
ruby 2.4.10p364 (2020-03-31 revision 67879) [x86_64-darwin17]
% ruby --enable-did-you-mean -e 'DidYouMean'
% ruby --disable-did-you-mean -e 'DidYouMean'
-e:1:in `<main>': uninitialized constant DidYouMean (NameError) or % RUBYOPT='--enable-did-you-mean' ruby -e 'DidYouMean'
% RUBYOPT='--disable-did-you-mean' ruby -e 'DidYouMean'
-e:1:in `<main>': uninitialized constant DidYouMean (NameError) However, I'm not sure about that is affecting the problem... 🤔 |
And I agree with this. |
I just ran into this issue as well, but like you I haven’t figured out what the underlying problem is. @koic I didn’t know about the enable/disable option for this feature, but judging from these different error messages it’s not the problem we are looking for:
|
Sorry. Let’s keep the discussion in #7979 from here on. |
rails server |
It looks like a Thor error, not a RuboCop error. JFYI, rails/thor#761 for fix to the issue is already open. |
thanks a lot. |
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.