Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor #8150

Commits on Jun 13, 2020

  1. Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor

    This PR fixes the following false positive for `Layout/EmptyLinesAroundAttributeAccessor`
    when using attribute accessors in `if` ... `else` branches.
    
    ```ruby
    if condition
      attr_reader :foo
    else
      do_something
    end
    ```
    
    ```console
    % bundle exec rubocop --only Layout/EmptyLinesAroundAttributeAccessor
    (snip)
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:2:3: C: Layout/EmptyLinesAroundAttributeAccessor: Add an
    empty line after attribute accessor.
      attr_reader :foo
      ^^^^^^^^^^^^^^^^
    
    1 file inspected, 1 offense detected
    ```
    koic committed Jun 13, 2020
    Copy the full SHA
    47f1300 View commit details
    Browse the repository at this point in the history