Inline ParserDiagnostic module
#8442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow rubocop#8395 (comment). This PR does a refactoring to inline `ParserDiagnostic` module. It seems that it is simpler and easier to maintain if it is implemented by each cop rather than mix-in the module. I don't think `ParserDiagnostic` module is used outside of RuboCop core, at least not in the RuboCop HQ products. On the other hand, I added it to the changelog just in case for 3rd party gems.
bbatsov
approved these changes
Aug 3, 2020
8 tasks
|
Great, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #8395 (comment).
This PR does a refactoring to inline
ParserDiagnosticmodule.It seems that it is simpler and easier to maintain if it is implemented by each cop rather than mix-in the module.
I don't think
ParserDiagnosticmodule is used outside of RuboCop core, at least not in the RuboCop HQ products.On the other hand, I added it to the changelog just in case for 3rd party gems.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.