Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocorrect for percent literal array with newlines #8481

Merged
merged 1 commit into from Aug 7, 2020

Conversation

@biinari
Copy link
Contributor

@biinari biinari commented Aug 7, 2020

Fix line number when array element contains newline so that extra newlines
are not added to the result

Use expect_correction for embedded newline in percent literal array


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@biinari biinari force-pushed the Fatsoma:fix/word_array_newlines branch from 607c53f to ce317de Aug 7, 2020
@koic
koic approved these changes Aug 7, 2020
Copy link
Member

@koic koic left a comment

👍

@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Aug 7, 2020

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

Fix line number when array element contains newline so that extra newlines
are not added to the result

Use expect_correction for embedded newline in percent literal array
@biinari biinari force-pushed the Fatsoma:fix/word_array_newlines branch from ce317de to 86b1bd5 Aug 7, 2020
@biinari
Copy link
Contributor Author

@biinari biinari commented Aug 7, 2020

No problem. Rebased on master.

@koic koic merged commit db2b36e into rubocop-hq:master Aug 7, 2020
26 checks passed
26 checks passed
windows 2.4
Details
windows 2.5
Details
windows 2.6
Details
windows 2.7
Details
windows mingw
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@koic
Copy link
Member

@koic koic commented Aug 7, 2020

Thank you!

@biinari biinari deleted the Fatsoma:fix/word_array_newlines branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.