Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-correction for Naming/BinaryOperatorParameterName #8982

Conversation

koic
Copy link
Member

@koic koic commented Oct 31, 2020

This PR supports auto-correction for Naming/BinaryOperatorParameterName.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 31, 2020

The changes seem solid. I'd suggest starting to use the new changelog directory instead of modifying the CHANGELOG.md directly to avoid having to deal with the merge conflicts. Just realized we updated the contribution guidelines, but not the PR template to recommend creating entries in the folder.

This PR supports auto-correction for `Naming/BinaryOperatorParameterName`.
@koic koic force-pushed the support_autocorrect_for_binary_operator_parameter_name branch from fcf423b to 062541f Compare November 1, 2020 01:41
@koic
Copy link
Member Author

koic commented Nov 1, 2020

I updated this PR with the new method of updating the changelog. I was used to updating the changelog directly, so I chose that 😅

@bbatsov bbatsov merged commit 151f079 into rubocop:master Nov 1, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 1, 2020

Thanks!

@koic koic deleted the support_autocorrect_for_binary_operator_parameter_name branch November 1, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants