Add new Layout/SpaceBeforeBrackets cop
#9231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_layout_space_before_brackets
branch
from
c5b8207
to
4fedf92
Compare
koic
changed the title
Layout/SpaceBeforeBrackets copLayout/SpaceBeforeBrackets cop
Follow rubocop/ruby-style-guide#856. This PR adds new `Layout/SpaceBeforeBrackets` cop. ```ruby # bad collection [index_or_key] # good collection[index_or_key] ``` This cop is marked as unsafe because it can occur false positives for `do_something [this_is_an_array_literal_argument]` that take an array without parentheses as an argument. I noticed this issue below. https://github.com/rsim/oracle-enhanced/pull/2076/files# diff-0d21136da5aee9b25213dcf874f62418fa24a06a90237e069642a5af54e7b2efL494-R494
koic
force-pushed
the
add_new_layout_space_before_brackets
branch
from
4fedf92
to
9cfced1
Compare
koic
changed the title
Layout/SpaceBeforeBrackets copLayout/SpaceBeforeBrackets cop
|
Thanks! |
koic
added a commit
that referenced
this pull request
Dec 17, 2020
Follow #9231. This commit removes unused `def_node_matcher`. It was not removed from the generator template.
|
Is it meant to apply in the following case |
|
This case will be ignored, unless |
|
Just seen the fix #9291. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/ruby-style-guide#856.
This PR adds new
Layout/SpaceBeforeBracketscop.This cop is marked as unsafe because it can occur false positives for
do_something [this_is_an_array_literal_argument]that take an array without parentheses as an argument.I noticed this issue below.
https://github.com/rsim/oracle-enhanced/pull/2076/files#diff-0d21136da5aee9b25213dcf874f62418fa24a06a90237e069642a5af54e7b2efL494-R494
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.