Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Style/MethodDefParentheses to ignore endless method definitions since parentheses are always required #9278

Merged
merged 1 commit into from Dec 23, 2020

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Dec 22, 2020

Endless methods require parentheses as part of the definition, or else it is a syntax error. Therefore, Style/MethodDefParentheses should never consider endless methods, as rewriting to remove the parens would lead to invalid code.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ons since parentheses are always required.
@dvandersluis dvandersluis changed the title Add support for endless methods to Style/MethodDefParentheses. Update Style/MethodDefParentheses to ignore endless method definitions since parentheses are always required Dec 23, 2020
@bbatsov bbatsov merged commit 7b65c6c into rubocop:master Dec 23, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 23, 2020

Great work!

@dvandersluis dvandersluis deleted the fix/method-def-parentheses branch January 18, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants