Expound on alias vs alias_method appropriateness
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we're off to a good start here, but I think we can do a bit better:
|
|
Fixed it up a bit and incorporated your suggestions. Do you think the explanation of aliasing and inheritance is clear enough? |
| @@ -2447,6 +2447,73 @@ condition](#safe-assignment-in-condition). | |||
| end | |||
| ``` | |||
|
|
|||
| * <a name="alias-method-lexically"></a> | |||
|
|
|||
Added examples of when one is more appropriate over the other, and notes about aliasing and inheritance.
bbatsov
added a commit
that referenced
this pull request
Dec 5, 2014
Expound on `alias` vs `alias_method` appropriateness
|
👍 |
marocchino
pushed a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
Expound on `alias` vs `alias_method` appropriateness
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Expound on `alias` vs `alias_method` appropriateness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides examples of when
aliasis more appropriate thanalias_methodand vice versa, as discussed in issue #377.