Sets should only be used for unique elements. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The text is written as is to clarify that Arrays can be used as sets (they support set operations), but if you have lots of elements a Set would perform a lot better. |
|
As long as all elements are unique. And not all Set operations are faster than it's Array counterparts, only lookup-based ones, like #find, #delete and #include?. |
|
I meant things like union, intersection, etc. I guess both entries should be expanded a bit. |
|
Yes, that'd be good. |
marocchino
pushed a commit
to marocchino/ruby-style-guide
that referenced
this pull request
Aug 11, 2015
shyouhei
pushed a commit
to shyouhei/ruby-style-guide
that referenced
this pull request
Nov 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes text about Sets, since they only store unique elements.