Add "No mix named and numbered captures" rule #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
koic
reviewed
Feb 24, 2020
pocke
force-pushed
the
no-mix-named-and-numbered-captures
branch
from
f63356e
to
b04abc7
Compare
koic
approved these changes
Feb 24, 2020
bbatsov
reviewed
Feb 26, 2020
README.adoc
Outdated
| @@ -4336,6 +4336,26 @@ Use non-capturing groups when you don't use the captured result. | |||
| /(?:first|second)/ | |||
| ---- | |||
|
|
|||
| === No mix named and numbered captures [[no-mix-named-and-numbered-captures]] | |||
There was a problem hiding this comment.
I think Do not mix... is better wording here. Same for the anchor.
bbatsov
reviewed
Feb 26, 2020
| === No mix named and numbered captures [[no-mix-named-and-numbered-captures]] | ||
|
|
||
| Do not mix named captures and numbered captures in a Regexp literal. | ||
| Because numbered capture is ignored if they're mixed. |
There was a problem hiding this comment.
Might be a good idea to illustrate what does this mean in practice.
bbatsov
reviewed
Feb 26, 2020
README.adoc
Outdated
| # good | ||
| /(?<foo>FOO)(?<bar>BAR)/ | ||
|
|
||
| # good |
There was a problem hiding this comment.
I'd add some comments explaining examples like this one, as I'm pretty sure many people are not familiar with non-capturing groups.
|
Thanks! Great work! 🙇 |
olleolleolle
added a commit
to github-changelog-generator/github-changelog-generator
that referenced
this pull request
Jun 3, 2020
- This rule is rubocop/ruby-style-guide#793 - Perhaps we can investigate what can be done with this regular expression, to not need those extra capture groups?
olleolleolle
added a commit
to github-changelog-generator/github-changelog-generator
that referenced
this pull request
Oct 30, 2020
- This rule is rubocop/ruby-style-guide#793 - Perhaps we can investigate what can be done with this regular expression, to not need those extra capture groups?
olleolleolle
added a commit
to github-changelog-generator/github-changelog-generator
that referenced
this pull request
Nov 21, 2020
- This rule is rubocop/ruby-style-guide#793 - Perhaps we can investigate what can be done with this regular expression, to not need those extra capture groups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created Lint/MixedRegexpCaptureTypes cop in rubocop/rubocop#7749.
This pull request adds a mention of the problem to the style guide also.