We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all
I suggest to add description about Active Record redundant all.
I often come across all used as receiver of Active Record query methods.
# bad User.all.order(:created_at) User.all.find(id) User.all.where(id: ids) # good User.order(:created_at) User.find(id) User.where(id: ids)
In these cases, the output is same with or without all, so I think it's redundant and could be removed.
If there's a positive reaction to this issue, I plan to submit a PR.
The text was updated successfully, but these errors were encountered:
Rails/RedundantActiveRecordAllMethod
@masato-bkn There is no issue if the redundant all method call will be removed. Can you open a PR?
Sorry, something went wrong.
No branches or pull requests
I suggest to add description about Active Record redundant
all
.I often come across
all
used as receiver of Active Record query methods.In these cases, the output is same with or without
all
, so I think it's redundant and could be removed.If there's a positive reaction to this issue, I plan to submit a PR.
The text was updated successfully, but these errors were encountered: