-
-
Notifications
You must be signed in to change notification settings - Fork 43
/
assert_predicate_test.rb
165 lines (148 loc) · 4.13 KB
/
assert_predicate_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
# frozen_string_literal: true
require 'test_helper'
class AssertPredicateTest < Minitest::Test
def test_registers_offense_when_using_assert_with_predicate_method
assert_offense(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(obj.one?)
^^^^^^^^^^^^^^^^ Prefer using `assert_predicate(obj, :one?)`.
end
end
RUBY
assert_correction(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(obj, :one?)
end
end
RUBY
end
def test_registers_offense_when_using_assert_with_predicate_method_and_message
assert_offense(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(obj.one?, 'message')
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_predicate(obj, :one?, 'message')`.
end
end
RUBY
assert_correction(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(obj, :one?, 'message')
end
end
RUBY
end
def test_registers_offense_when_using_assert_with_predicate_method_and_heredoc_message
assert_offense(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(obj.one?, <<~MESSAGE)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_predicate(obj, :one?, <<~MESSAGE)`.
message
MESSAGE
end
end
RUBY
assert_correction(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(obj, :one?, <<~MESSAGE)
message
MESSAGE
end
end
RUBY
end
def test_registers_offense_when_using_assert_with_predicate_method_in_redundant_parentheses
assert_offense(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert((obj.one?))
^^^^^^^^^^^^^^^^^^ Prefer using `assert_predicate(obj, :one?)`.
end
end
RUBY
assert_correction(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(obj, :one?)
end
end
RUBY
end
def test_registers_offense_when_using_assert_with_receiver_omitted_predicate_method
assert_offense(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(one?)
^^^^^^^^^^^^ Prefer using `assert_predicate(self, :one?)`.
end
end
RUBY
assert_correction(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(self, :one?)
end
end
RUBY
end
def test_does_not_register_offense_when_using_assert_predicate_method
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert_predicate(obj, :one?)
end
end
RUBY
end
def test_does_not_registers_offense_when_using_assert_with_non_predicate_method
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(obj.do_something)
end
end
RUBY
end
def test_does_not_registers_offense_when_using_assert_with_local_variable
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
obj = create_obj
assert(obj)
end
end
RUBY
end
def test_does_not_register_offense_when_using_assert_with_predicate_method_and_arguments
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert(obj.foo?(arg))
end
end
RUBY
end
def test_does_not_register_offense_when_using_assert_with_predicate_method_and_numbered_parameters
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert([1, 2, 3].any? { some_filter_function _1 })
end
end
RUBY
end
def test_does_not_raise_error_using_assert_with_block
assert_no_offenses(<<~RUBY)
class FooTest < Minitest::Test
def test_do_something
assert { true }
end
end
RUBY
end
end