Skip to content

Commit

Permalink
Tweak the PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
koic committed Dec 6, 2021
1 parent ba69221 commit a7af7bc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ The more detailed you are, the better.**

Before submitting the PR make sure the following are checked:

* [ ] The PR relates to *only* one subject with a clear title and description in grammatically correct, complete sentences.
* [ ] Wrote [good commit messages][1].
* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).
* [ ] Feature branch is up-to-date with `master` (if not - rebase it).
* [ ] Squashed related commits together.
* [ ] Added tests.
* [ ] Ran `bundle exec rake default`. It executes all tests and runs RuboCop on its own code.
* [ ] Added an entry (file) to the [changelog folder](https://github.com/rubocop/rubocop-rails/blob/master/changelog/) named `{change_type}_{change_description}.md` if the new code introduces user-observable changes. See [changelog entry format](https://github.com/rubocop/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format) for details.
* [ ] The PR relates to *only* one subject with a clear title
and description in grammatically correct, complete sentences.
* [ ] Run `bundle exec rake default`. It executes all tests and RuboCop for itself, and generates the documentation.
* [ ] If this is a new cop, consider making a corresponding update to the [Rails Style Guide](https://github.com/rubocop-hq/rails-style-guide).

This comment has been minimized.

Copy link
@pirj

pirj Dec 8, 2021

Member

I think this item was useful to bring the guide to a better shape. Some people submit cops, but are hesitant to tweak the style guide.

This comment has been minimized.

Copy link
@andyw8

andyw8 Dec 8, 2021

Contributor

Also I think having a discussion on the style guide is a better way to determine a consensus before 'formalizing' it as a cop.

This comment has been minimized.

Copy link
@koic

koic Dec 9, 2021

Author Member

It was accidentally deleted, so I restored it.
584deee


[1]: https://chris.beams.io/posts/git-commit/

0 comments on commit a7af7bc

Please sign in to comment.