Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/MixinUsage in default rails app #13

Closed
printercu opened this issue Sep 19, 2018 · 4 comments
Closed

Style/MixinUsage in default rails app #13

printercu opened this issue Sep 19, 2018 · 4 comments

Comments

@printercu
Copy link

Moved from rubocop/rubocop#5237

Every fresh rails app has bin/{setup,update} with toplevel include FileUtils.

This cop does not provide autofix, and to fix this warning it requires remastering this files, which results in conflicts when updating rails.

Should this files be added to default exclude list for this cop?

@tjustino
Copy link

tjustino commented Mar 6, 2019

With the last releases, this issue doesn't appear anymore (tested this morning with an update to rails 6.0.0.beta2 and rubocop 0.65.0).
It seems this issue can be closed.

@andyw8
Copy link
Contributor

andyw8 commented Mar 6, 2019

For reference, here's where it was changed: rails/rails#34084

@andyw8
Copy link
Contributor

andyw8 commented Mar 6, 2019

I'd say this is still an issue since many people will be using Rails 5 or older.

@koic
Copy link
Member

koic commented Mar 28, 2020

I think this issue has been resolved by #168.

@koic koic closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants