/
literal_as_condition_spec.rb
262 lines (232 loc) · 6.39 KB
/
literal_as_condition_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::LiteralAsCondition, :config do
%w(1 2.0 [1] {} :sym :"#{a}").each do |lit|
it "registers an offense for literal #{lit} in if" do
expect_offense(<<~RUBY, lit: lit)
if %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in while" do
expect_offense(<<~RUBY, lit: lit)
while %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in post-loop while" do
expect_offense(<<~RUBY, lit: lit)
begin
top
end while(%{lit})
^{lit} Literal `#{lit}` appeared as a condition.
RUBY
end
it "registers an offense for literal #{lit} in until" do
expect_offense(<<~RUBY, lit: lit)
until %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in post-loop until" do
expect_offense(<<~RUBY, lit: lit)
begin
top
end until %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
RUBY
end
it "registers an offense for literal #{lit} in case" do
expect_offense(<<~RUBY, lit: lit)
case %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
when x then top
end
RUBY
end
it "registers an offense for literal #{lit} in a when " \
'of a case without anything after case keyword' do
expect_offense(<<~RUBY, lit: lit)
case
when %{lit} then top
^{lit} Literal `#{lit}` appeared as a condition.
end
RUBY
end
it "accepts literal #{lit} in a when of a case with something after case keyword" do
expect_no_offenses(<<~RUBY)
case x
when #{lit} then top
end
RUBY
end
context '>= Ruby 2.7', :ruby27 do
it "registers an offense for literal #{lit} in case match" do
expect_offense(<<~RUBY, lit: lit)
case %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
in x then top
end
RUBY
end
it "accepts literal #{lit} in a when of a case match" do
expect_no_offenses(<<~RUBY)
case x
in #{lit} then top
end
RUBY
end
end
it "registers an offense for literal #{lit} in &&" do
expect_offense(<<~RUBY, lit: lit)
if x && %{lit}
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in complex cond" do
expect_offense(<<~RUBY, lit: lit)
if x && !(a && %{lit}) && y && z
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in !" do
expect_offense(<<~RUBY, lit: lit)
if !%{lit}
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "registers an offense for literal #{lit} in complex !" do
expect_offense(<<~RUBY, lit: lit)
if !(x && (y && %{lit}))
^{lit} Literal `#{lit}` appeared as a condition.
top
end
RUBY
end
it "accepts literal #{lit} if it's not an and/or operand" do
expect_no_offenses(<<~RUBY)
if test(#{lit})
top
end
RUBY
end
it "accepts literal #{lit} in non-toplevel and/or" do
expect_no_offenses(<<~RUBY)
if (a || #{lit}).something
top
end
RUBY
end
it "registers an offense for `!#{lit}`" do
expect_offense(<<~RUBY, lit: lit)
!%{lit}
^{lit} Literal `#{lit}` appeared as a condition.
RUBY
end
it "registers an offense for `not #{lit}`" do
expect_offense(<<~RUBY, lit: lit)
not(%{lit})
^{lit} Literal `#{lit}` appeared as a condition.
RUBY
end
end
it 'accepts array literal in case, if it has non-literal elements' do
expect_no_offenses(<<~RUBY)
case [1, 2, x]
when [1, 2, 5] then top
end
RUBY
end
it 'accepts array literal in case, if it has nested non-literal element' do
expect_no_offenses(<<~RUBY)
case [1, 2, [x, 1]]
when [1, 2, 5] then top
end
RUBY
end
it 'registers an offense for case with a primitive array condition' do
expect_offense(<<~RUBY)
case [1, 2, [3, 4]]
^^^^^^^^^^^^^^ Literal `[1, 2, [3, 4]]` appeared as a condition.
when [1, 2, 5] then top
end
RUBY
end
it 'accepts dstr literal in case' do
expect_no_offenses(<<~'RUBY')
case "#{x}"
when [1, 2, 5] then top
end
RUBY
end
context '>= Ruby 2.7', :ruby27 do
it 'accepts array literal in case match, if it has non-literal elements' do
expect_no_offenses(<<~RUBY)
case [1, 2, x]
in [1, 2, 5] then top
end
RUBY
end
it 'accepts array literal in case match, if it has nested non-literal element' do
expect_no_offenses(<<~RUBY)
case [1, 2, [x, 1]]
in [1, 2, 5] then top
end
RUBY
end
it 'registers an offense for case match with a primitive array condition' do
expect_offense(<<~RUBY)
case [1, 2, [3, 4]]
^^^^^^^^^^^^^^ Literal `[1, 2, [3, 4]]` appeared as a condition.
in [1, 2, 5] then top
end
RUBY
end
it 'accepts dstr literal in case match' do
expect_no_offenses(<<~'RUBY')
case "#{x}"
in [1, 2, 5] then top
end
RUBY
end
end
it 'accepts `true` literal in `while`' do
expect_no_offenses(<<~RUBY)
while true
break if condition
end
RUBY
end
it 'accepts `true` literal in post-loop `while`' do
expect_no_offenses(<<~RUBY)
begin
break if condition
end while true
RUBY
end
it 'accepts `false` literal in `until`' do
expect_no_offenses(<<~RUBY)
until false
break if condition
end
RUBY
end
it 'accepts `false` literal in post-loop `until`' do
expect_no_offenses(<<~RUBY)
begin
break if condition
end until false
RUBY
end
end