-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
to_enum_arguments_spec.rb
151 lines (134 loc) · 4.8 KB
/
to_enum_arguments_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::ToEnumArguments, :config do
it 'registers an offense when required arg is missing' do
expect_offense(<<~RUBY)
def m(x)
return to_enum(:m) unless block_given?
^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when optional arg is missing' do
expect_offense(<<~RUBY)
def m(x, y = 1)
return to_enum(:m, x) unless block_given?
^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when splat arg is missing' do
expect_offense(<<~RUBY)
def m(x, y = 1, *args)
return to_enum(:m, x, y) unless block_given?
^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when required keyword arg is missing' do
expect_offense(<<~RUBY)
def m(x, y = 1, *args, required:)
return to_enum(:m, x, y, *args) unless block_given?
^^^^^^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when optional keyword arg is missing' do
expect_offense(<<~RUBY)
def m(x, y = 1, *args, required:, optional: true)
return to_enum(:m, x, y, *args, required: required) unless block_given?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when splat keyword arg is missing' do
expect_offense(<<~RUBY)
def m(x, y = 1, *args, required:, optional: true, **kwargs)
return to_enum(:m, x, y, *args, required: required, optional: optional) unless block_given?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when arguments are swapped' do
expect_offense(<<~RUBY)
def m(x, y = 1)
return to_enum(:m, y, x) unless block_given?
^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when other values are passed for keyword arguments' do
expect_offense(<<~RUBY)
def m(required:, optional: true)
return to_enum(:m, required: something_else, optional: optional) unless block_given?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'does not register an offense when not inside method definition' do
expect_no_offenses(<<~RUBY)
to_enum(:m)
RUBY
end
it 'does not register an offense when method call has a receiver other than `self`' do
expect_no_offenses(<<~RUBY)
def m(x)
return foo.to_enum(:m) unless block_given?
end
RUBY
end
it 'registers an offense when method is called on `self`' do
expect_offense(<<~RUBY)
def m(x)
return self.to_enum(:m) unless block_given?
^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'ignores the block argument' do
expect_no_offenses(<<~RUBY)
def m(x, &block)
return to_enum(:m, x) unless block_given?
end
RUBY
end
it 'registers an offense when enumerator is created for another method' do
expect_offense(<<~RUBY)
def m(x)
return to_enum(:not_m) unless block_given?
^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'registers an offense when enumerator is created for `__method__`' do
expect_offense(<<~RUBY)
def m(x)
return to_enum(__method__) unless block_given?
^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'does not register an offense when enumerator is created with the correct arguments' do
expect_no_offenses(<<~RUBY)
def m(x, y = 1, *args, required:, optional: true, **kwargs, &block)
return to_enum(:m, x, y, *args, required: required, optional: optional, **kwargs) unless block_given?
end
RUBY
end
context 'arguments forwarding', :ruby30 do
it 'registers an offense when enumerator is created with non matching arguments' do
expect_offense(<<~RUBY)
def m(...)
return to_enum(:m, x, ...) unless block_given?
^^^^^^^^^^^^^^^^^^^ Ensure you correctly provided all the arguments.
end
RUBY
end
it 'does not register an offense when enumerator is created with the correct arguments' do
expect_no_offenses(<<~RUBY)
def m(...)
return to_enum(:m, ...) unless block_given?
end
RUBY
end
end
end