Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Indentation for the Layout/MultilineMethodCallIndentation cop #12428

Open
ydakuka opened this issue Dec 1, 2023 · 2 comments
Open

Wrong Indentation for the Layout/MultilineMethodCallIndentation cop #12428

ydakuka opened this issue Dec 1, 2023 · 2 comments

Comments

@ydakuka
Copy link

ydakuka commented Dec 1, 2023

Actual behavior

def parse_user_params
  params[:user] =
    params[:user]&.permit(*policy(User).permitted_attributes).to_h
    .merge(
      params[:user_form]
      &.permit(*policy(UserForm).permitted_attributes)
      .to_h,
    )
end

I run the command rubocop -A and I get:

def parse_user_params
  params[:user] =
    params[:user]&.permit(*policy(User).permitted_attributes).to_h
                 .merge(
                   params[:user_form]
                   &.permit(*policy(UserForm).permitted_attributes)
                   .to_h,
                 )
end

Expected behavior

def parse_user_params
  params[:user] =
    params[:user]
    &.permit(*policy(User).permitted_attributes)
    .to_h
    .merge(
      params[:user_form]
      &.permit(*policy(UserForm).permitted_attributes)
      .to_h,
    )
end

or

def parse_user_params
  params[:user] =
    params[:user]&.permit(*policy(User).permitted_attributes)
                 .to_h
                 .merge(
                   params[:user_form]
                   &.permit(*policy(UserForm).permitted_attributes)
                   .to_h,
                 )
end

RuboCop version

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydakuka
Copy link
Author

ydakuka commented Dec 1, 2023

And the second case:

I have the following code:

def parse_user_params
  params[:user] =
    params[:user]&.permit(*policy(User).permitted_attributes)&.to_h
    &.merge(
      params[:user_form]
      &.permit(*policy(UserForm).permitted_attributes)
      .to_h,
    )
end

I run rubocop -A and get:

def parse_user_params
  params[:user] =
    params[:user]&.permit(*policy(User).permitted_attributes)&.to_h
                 &.merge(
                   params[:user_form]
    &.permit(*policy(UserForm).permitted_attributes)
    .to_h,
                 )
end

@koic
Copy link
Member

koic commented Dec 1, 2023

Layout/MultilineMethodCallIndentation is for organizing the indentation of multiline method calls that are already broken into multiple lines, not for introducing new line breaks in method chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants