Version 0.5.0 fails to run

[shmeltex]

After upgrading to version 0.5.0, rubocop started to fail with the following error:

xxxx$ rubocop app
/Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:182:in `block in ruby_files': invalid byte sequence in UTF-8 (ArgumentError)
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:180:in `select'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:180:in `ruby_files'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:157:in `block in target_files'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:155:in `each'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:155:in `target_files'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/lib/rubocop/cli.rb:44:in `run'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/bin/rubocop:13:in `block in <top (required)>'
    from /Users/xxxx/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/benchmark.rb:296:in `realtime'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/gems/rubocop-0.5.0/bin/rubocop:12:in `<top (required)>'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/bin/rubocop:23:in `load'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/bin/rubocop:23:in `<main>'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `eval'
    from /Users/xxxx/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `<main>'

Version 0.4.6 worked with no issues on the same set of source code.

[bbatsov]

Maybe @lee-dohm can have a look at the problem? 0.5.0 runs fine on all codebases I've tested it on.

[shmeltex]

The error caused by having binary file without extension in one of the sub-directories

[cschramm]

I've had this too due to old stuff in my tmp directory. Clearing it fixed the problem.

[bf4]

Fixed in #67 (and see #69 for good measure)

[lee-dohm]

I think @bf4 has the right solution, catch the issues and return false ... logging on debug of course.

[bf4]

@lee-dohm Thanks. And since this part of the code is really only checking if a file without a .rb extension contains ruby code, I thought that unreadable or unparseable file could be safely ignored. Perhaps instead of STDERR we should use a logger, but that is besides the point of getting the thing to work... It can be put off till a future iteration.

[bbatsov]

Thanks for looking into that @bf4! Btw, you could have simply used warn :-)