Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading 0.64.0 to 0.65.0 causes 'TypeError: superclass mismatch for class Mark' #6781

Closed
henrik opened this issue Feb 20, 2019 · 11 comments · Fixed by #6885
Closed

Upgrading 0.64.0 to 0.65.0 causes 'TypeError: superclass mismatch for class Mark' #6781

henrik opened this issue Feb 20, 2019 · 11 comments · Fixed by #6885

Comments

@henrik
Copy link

henrik commented Feb 20, 2019

Seems to be related to psych – please see ruby/psych#386 for details.

@Drenmi
Copy link
Collaborator

Drenmi commented Feb 21, 2019

Hi, @henrik!

Good to see that you’re staying on top of dependency updates. 🙂

We’ve seen some other problems with Psych on Windows and Ruby 2.6. (ruby/psych#385) What platform and Ruby version are you on?

@henrik
Copy link
Author

henrik commented Feb 21, 2019

Hi; thanks :)

This is Ruby 2.5.3 and I believe the VMs in CircleCI run on some Linux distro. Let me know if you want the exact one!

@Jatkins1995
Copy link

@henrik Facing the same problem. Have you had any luck finding a solution?

@henrik
Copy link
Author

henrik commented Mar 4, 2019 via email

@hirowatari
Copy link

Same issue here. Using ruby 2.5.3, ubuntu 18.04. I've locked Rubocop to 0.64.0 to workaround the issue for now.

@Drenmi
Copy link
Collaborator

Drenmi commented Mar 6, 2019

@Jatkins1995, @hirowatari Are you both experiencing this problem in CircleCI? Or in your local environment? I have no problem in neither. 😞

@hirowatari
Copy link

@Drenmi No I'm not using CircleCI. I'm using a local development environment.

@erikaxel
Copy link

erikaxel commented Mar 6, 2019

We also have this issue on our CI. Ruby 2.5.3. It is a docker container based on Ruby which builds on Debian Stretch. I think it is because of this change: https://github.com/rubocop-hq/rubocop/pull/6766/files#diff-458bc38d82061cdac508dfb1be2b918bR41

Is adding psych as a runtime dependency necessary?

@coldnebo
Copy link

coldnebo commented Mar 8, 2019

We're having a similar issue. We are using Ruby 2.3.7 currently and Psych 3.1.0 conflicts on Ruby load. We can't fix it by adding it to our Gemfile.

I'm going to advise to work around this for now.

gem 'rubocop', '<= 0.64.0'`

Psych is tightly integrated to Ruby core, so it is dangerous for Rubocop to spec it without a higher ruby version requirement.

Note:

  • Ruby 2.6.1 depends on psych 3.1.0
  • Ruby 2.6.0 made the switch to psych 3.1.0
  • Ruby 2.5.0 made the switch to psych 3.0.0
  • Ruby 2.3.7 depends on psych 2.1.0.1

@hirowatari
Copy link

Thanks for fixing this!

@andreaseger
Copy link
Contributor

andreaseger commented Apr 4, 2019

Is somebody tracking this issue? This is also causing us some headaches using jruby because now it pulls in a maven environment to be able to install psych from source.

Until this gets reverted to use the psych version packaged in the standard lib we cannot update rubocop any longer which is a shame.

If needed I can open a PR which reverts the relevant bits from #6766 just created a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants