expect_correction & successive transformations

[marcandre]

As a followup to #8062, when testing for a cop that relies on successive autocorrections:

• should we be more specific with spec'ing the intermediate steps?
• or should we spec that a step leads to the expected correction (as @pirj suggests)?
• or should we not always test only using the final stable step?

[bquorning]

I have found only two specs (and both in the same file) that separately tests the result after one autocorrect and the result after looped autocorrects: https://github.com/rubocop-hq/rubocop/blob/774fe63486f6aa947dfe2e4f1d122c4fa48db080/spec/rubocop/cop/style/conditional_assignment_assign_to_condition_spec.rb#L46-L99 and https://github.com/rubocop-hq/rubocop/blob/774fe63486f6aa947dfe2e4f1d122c4fa48db080/spec/rubocop/cop/style/conditional_assignment_assign_to_condition_spec.rb#L2197-L2243

I have of course also found some tests that produce different results when looping autocorrects vs. running just one autocorrect. Some of these are quite silly, e.g. https://github.com/rubocop-hq/rubocop/blob/774fe63486f6aa947dfe2e4f1d122c4fa48db080/spec/rubocop/cop/layout/space_inside_array_literal_brackets_spec.rb#L522-L535 which says “Do not use space inside array brackets” and then promptly adds an offending space at the other end of the array.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!