An error occurred while Rails/Blank cop was inspecting #4179

ivanovaleksey · 2017-03-27T09:47:05Z

Hi,

I have few code snippet which somehow makes Rubocop to fail.

def end_date
  harvested_at || season.try(:dt_to)
end

Expected behavior

I expect Rubocop not to fail and just report offense.

Actual behavior

Rubocop fails with the following backtrace:

/Users/aleksey/projects/rubocop/lib/rubocop/cop/rails/blank.rb:45:in `nil_or_empty?'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/rails/blank.rb:80:in `on_or'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:43:in `block (2 levels) in on_or'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:106:in `with_cop_error_handling'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:42:in `block in on_or'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:41:in `each'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:41:in `on_or'
/Users/aleksey/projects/rubocop/lib/rubocop/ast/traversal.rb:95:in `on_def'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:47:in `on_def'
(eval):2:in `block in on_begin'
(eval):2:in `each'
(eval):2:in `on_begin'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:47:in `on_begin'
/Users/aleksey/projects/rubocop/lib/rubocop/ast/traversal.rb:88:in `on_class'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:47:in `on_class'
/Users/aleksey/projects/rubocop/lib/rubocop/ast/traversal.rb:12:in `walk'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/commissioner.rb:60:in `investigate'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/team.rb:124:in `investigate'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/team.rb:112:in `offenses'
/Users/aleksey/projects/rubocop/lib/rubocop/cop/team.rb:54:in `inspect_file'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:248:in `inspect_file'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:195:in `block in do_inspection_loop'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:227:in `block in iterate_until_no_changes'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:220:in `loop'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:220:in `iterate_until_no_changes'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:191:in `do_inspection_loop'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:101:in `block in file_offenses'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:111:in `file_offense_cache'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:99:in `file_offenses'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:90:in `process_file'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:68:in `block in each_inspected_file'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:65:in `each'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:65:in `reduce'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:65:in `each_inspected_file'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:57:in `inspect_files'
/Users/aleksey/projects/rubocop/lib/rubocop/runner.rb:36:in `run'
/Users/aleksey/projects/rubocop/lib/rubocop/cli.rb:72:in `execute_runner'
/Users/aleksey/projects/rubocop/lib/rubocop/cli.rb:27:in `run'
/Users/aleksey/projects/rubocop/bin/rubocop:13:in `block in <top (required)>'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
/Users/aleksey/projects/rubocop/bin/rubocop:12:in `<top (required)>'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bin/rubocop:22:in `load'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bin/rubocop:22:in `<top (required)>'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:74:in `load'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:74:in `kernel_load'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli/exec.rb:27:in `run'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:335:in `exec'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:20:in `dispatch'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/cli.rb:11:in `start'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/exe/bundle:32:in `block in <top (required)>'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
/Users/aleksey/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.6/exe/bundle:24:in `<top (required)>'
/Users/aleksey/.rbenv/versions/2.3.3/bin/bundle:22:in `load'
/Users/aleksey/.rbenv/versions/2.3.3/bin/bundle:22:in `<main>'

Steps to reproduce the problem

Errors happen within my project. If I would just copy and paste those snippets in new dummy folder Rubocop would work just fine.
Is it something wrong with my configuration?

RuboCop version

Include the output of rubocop -V. Here's an example:

$ rubocop -V
0.48.0 (using Parser 2.3.3.1, running on ruby 2.3.3 x86_64-darwin16)
on master branch

The text was updated successfully, but these errors were encountered:

andreaswachowski · 2017-03-27T09:55:57Z

Looks like a duplicate of #4171.

ivanovaleksey · 2017-03-27T10:11:08Z

Thank @andreaswachowski and sorry: I forgot to search in closed issues 😞

ivanovaleksey · 2017-03-27T10:13:59Z

Works fine on master branch.

ivanovaleksey · 2017-03-27T14:27:48Z

It seems like I still have problems. I updated issue details (code snippet and backtrace) above.
It is on master branch.

ivanovaleksey · 2017-03-27T14:41:04Z

@Drenmi could you please take a look?

stiig · 2017-03-27T14:55:03Z

I have same issue.
This is the code that fails

  def user_signed_in?
    current_user.present?
  end

  def company_signed_in?
    current_company.present?
  end

  def authenticate_with_token!
    render json: { status: 401, errors: 'Not authenticated' } unless user_signed_in? || company_signed_in?
                                                                   ^error
  end

esambo · 2017-03-27T16:41:19Z

I get the same error because I'm using || in:

#!/usr/bin/env ruby
# frozen_string_literal: true

system('bundle check') || system!('bundle install')

I can fix it by:

replacing || with && which has the opposite meaning!
making the frozen_string_literal the first line
don't use version 0.48.0 but master

rrosenblum · 2017-03-27T21:22:17Z

This is related to #4171. It is slightly different though. The same kind of fix for #4171 can be used here. I will have a PR in a few minutes.

…is a naked falsiness check

ivanovaleksey · 2017-03-27T21:47:13Z

Thanks Ryan, I will try it tomorrow!

…ked falsiness check

ivanovaleksey closed this as completed Mar 27, 2017

ivanovaleksey reopened this Mar 27, 2017

afdev82 mentioned this issue Mar 27, 2017

Errors with Rails/Blank cop #4183

Closed

rrosenblum added a commit to rrosenblum/rubocop that referenced this issue Mar 27, 2017

[Fix rubocop#4179] Prevent Rails/Blank cop from breaking when LHS of …

58fe75c

…is a naked falsiness check

rrosenblum mentioned this issue Mar 27, 2017

[Fix #4179] Prevent Rails/Blank cop from breaking when LHS of is a naked falsiness check #4190

Merged

bbatsov closed this as completed in #4190 Mar 28, 2017

bbatsov pushed a commit that referenced this issue Mar 28, 2017

[Fix #4179] Prevent Rails/Blank cop from breaking when LHS of is a na…

246bef5

…ked falsiness check

andreaswachowski mentioned this issue Mar 29, 2017

Rubocop errors with ruby 2.4.0 #4207

Closed

rrosenblum mentioned this issue Mar 30, 2017

An error occurred while Rails/Blank cop was inspecting #4210

Closed

dependabot bot mentioned this issue Mar 12, 2021

Bump rubocop from 0.31.0 to 0.48.1 juslee/java-buildpack#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

An error occurred while Rails/Blank cop was inspecting #4179

An error occurred while Rails/Blank cop was inspecting #4179

ivanovaleksey commented Mar 27, 2017 •

edited

Loading

andreaswachowski commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017 •

edited

Loading

ivanovaleksey commented Mar 27, 2017

stiig commented Mar 27, 2017

esambo commented Mar 27, 2017

rrosenblum commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

An error occurred while Rails/Blank cop was inspecting #4179

An error occurred while Rails/Blank cop was inspecting #4179

Comments

ivanovaleksey commented Mar 27, 2017 • edited Loading

Expected behavior

Actual behavior

Steps to reproduce the problem

RuboCop version

andreaswachowski commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017 • edited Loading

ivanovaleksey commented Mar 27, 2017

stiig commented Mar 27, 2017

esambo commented Mar 27, 2017

rrosenblum commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017

ivanovaleksey commented Mar 27, 2017 •

edited

Loading

ivanovaleksey commented Mar 27, 2017 •

edited

Loading