Skip to content

Commit

Permalink
Regenerate client for real
Browse files Browse the repository at this point in the history
  • Loading branch information
@michaelklishin
michaelklishin committed Jun 22, 2012
1 parent d33f8f5 commit 4e96b71
Showing 1 changed file with 232 additions and 112 deletions.

5 comments on commit 4e96b71

@rubinix
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the support for Consumer Cancellations that @eliasevy put in was removed with this commit. The #decode method for the Cancel class was removed. Was this by intention or was it an accident?

@michaelklishin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't intentional but this is a limitation in rabbitmq-codegen: it should generate #decode for client extensions, too. Thanks for reporting.

@michaelklishin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in dc01fff, 0.9.2 and 1.0.0-pre5 are out to rubygems.org.

@rubinix
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks. This is my first go at using Rabbit and learning AMQP. I might take a stab at flowing this into Bunny.

@michaelklishin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunny is being rewritten at the moment. It will use amq-protocol as well once we are done.

Please sign in to comment.