-
Notifications
You must be signed in to change notification settings - Fork 304
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
issue656 - change recoverable_network_failure? to be a definable arra…
…y of exceptions and modify recover_from_network_failure to handle the exception logic differently
- Loading branch information
Showing
2 changed files
with
79 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
require 'spec_helper' | ||
|
||
describe Bunny::Session do | ||
context 'when created' do | ||
let(:io) { StringIO.new } # keep test output clear | ||
|
||
def create_session | ||
described_class.new( | ||
host: 'fake.host', | ||
recovery_attempts: 0, | ||
connection_timeout: 0, | ||
network_recovery_interval: 0, | ||
logfile: io, | ||
) | ||
end | ||
|
||
it 'has default exceptions' do | ||
session = create_session | ||
expect(session.recoverable_exceptions).to eq(Bunny::Session::DEFAULT_RECOVERABLE_EXCEPTIONS) | ||
end | ||
|
||
it 'can override exceptions' do | ||
session = create_session | ||
session.recoverable_exceptions = [StandardError] | ||
expect(session.recoverable_exceptions).to eq([StandardError]) | ||
end | ||
|
||
it 'can append exceptions' do | ||
session = create_session | ||
session.recoverable_exceptions << StandardError | ||
expect(session.recoverable_exceptions).to eq(Bunny::Session::DEFAULT_RECOVERABLE_EXCEPTIONS.append(StandardError)) | ||
end | ||
end | ||
|
||
context 'when retry attempts have been exhausted' do | ||
let(:io) { StringIO.new } # keep test output clear | ||
|
||
def create_session | ||
described_class.new( | ||
host: 'fake.host', | ||
recovery_attempts: 0, | ||
connection_timeout: 0, | ||
network_recovery_interval: 0, | ||
logfile: io, | ||
) | ||
end | ||
|
||
it 'closes the session' do | ||
session = create_session | ||
session.handle_network_failure(StandardError.new) | ||
expect(session.closed?).to be true | ||
end | ||
|
||
it 'stops the reader loop' do | ||
session = create_session | ||
reader_loop = session.reader_loop | ||
session.handle_network_failure(StandardError.new) | ||
expect(reader_loop.stopping?).to be true | ||
end | ||
end | ||
end |