Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes on release 2.4.0 #435

Closed
mynomoto opened this issue Sep 14, 2016 · 3 comments
Closed

Breaking changes on release 2.4.0 #435

mynomoto opened this issue Sep 14, 2016 · 3 comments

Comments

@mynomoto
Copy link

First thanks for this library. Being an open source maintainer is hard and usually unappreciated.

I'm not sure if this project follows semver or not, but we had trouble upgrading this library from version 2.3.1 to 2.5.1 because of e5d8cb3

Probably it was wrong to use the RABBITMQ_URL env and setting the vhost via options but this was surprising specially since there was no breaking change notice on the changelog.

@michaelklishin
Copy link
Member

I'm not sure what to say. There was a minor version bump. This is hardly a major API change.

@mynomoto
Copy link
Author

@michaelklishin Thanks for updating the changelog, it may save some trouble for others in the future

@michaelklishin
Copy link
Member

@mynomoto thank you for bringing this up to my attention 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants