Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunny::ConsumerWorkPool#shutdown(true) waits until timeout if the pool is not running. #438

Closed
Avemark opened this issue Oct 19, 2016 · 3 comments
Assignees
Labels

Comments

@Avemark
Copy link

@Avemark Avemark commented Oct 19, 2016

This is admittedly something of an edge case, but caused issues in the unit tests for our subclass of Bunny::Consumer.

Minimal reproduction:
Bunny::Consumer.new(Bunny.new(...).create_channel, "hello").cancel

michaelklishin added a commit that referenced this issue Oct 21, 2016
…active

Fixes #438.
@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Oct 21, 2016

@chav02 can you please try the tip of 2.6.x-stable or master (they are identical a.t.m.)?

@michaelklishin michaelklishin self-assigned this Oct 21, 2016
@Avemark
Copy link
Author

@Avemark Avemark commented Oct 24, 2016

@michaelklishin Tested with master, the issues we had are indeed fixed.

@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Oct 24, 2016

2.6.1 includes this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.