Bunny::ConsumerWorkPool#shutdown(true) waits until timeout if the pool is not running. #438

Closed
chav02 opened this Issue Oct 19, 2016 · 3 comments

Projects

None yet

2 participants

@chav02
chav02 commented Oct 19, 2016

This is admittedly something of an edge case, but caused issues in the unit tests for our subclass of Bunny::Consumer.

Minimal reproduction:
Bunny::Consumer.new(Bunny.new(...).create_channel, "hello").cancel

@michaelklishin michaelklishin added a commit that closed this issue Oct 21, 2016
@michaelklishin michaelklishin ConsumerWorkPool: don't wait for consumer shutdown if the pool isn't …
…active

Fixes #438.
24c2358
@michaelklishin michaelklishin added a commit that referenced this issue Oct 21, 2016
@michaelklishin michaelklishin ConsumerWorkPool: don't wait for consumer shutdown if the pool isn't …
…active

Fixes #438.
f9fdb80
@michaelklishin
Member

@chav02 can you please try the tip of 2.6.x-stable or master (they are identical a.t.m.)?

@michaelklishin michaelklishin self-assigned this Oct 21, 2016
@chav02
chav02 commented Oct 24, 2016

@michaelklishin Tested with master, the issues we had are indeed fixed.

@michaelklishin
Member

2.6.1 includes this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment