New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunny::ConsumerWorkPool#shutdown(true) waits until timeout if the pool is not running. #438

Closed
Avemark opened this Issue Oct 19, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Avemark

Avemark commented Oct 19, 2016

This is admittedly something of an edge case, but caused issues in the unit tests for our subclass of Bunny::Consumer.

Minimal reproduction:
Bunny::Consumer.new(Bunny.new(...).create_channel, "hello").cancel

michaelklishin added a commit that referenced this issue Oct 21, 2016

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Oct 21, 2016

Member

@chav02 can you please try the tip of 2.6.x-stable or master (they are identical a.t.m.)?

Member

michaelklishin commented Oct 21, 2016

@chav02 can you please try the tip of 2.6.x-stable or master (they are identical a.t.m.)?

@michaelklishin michaelklishin self-assigned this Oct 21, 2016

@Avemark

This comment has been minimized.

Show comment
Hide comment
@Avemark

Avemark Oct 24, 2016

@michaelklishin Tested with master, the issues we had are indeed fixed.

Avemark commented Oct 24, 2016

@michaelklishin Tested with master, the issues we had are indeed fixed.

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Oct 24, 2016

Member

2.6.1 includes this ;)

Member

michaelklishin commented Oct 24, 2016

2.6.1 includes this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment