Document Session options for logging. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document Session#initialize options:
* :logger
* :log_file
* :logfile
* :log_level
One of the guides mentions :logfile and :log_level, but not :logger
nor :logfile.
http://rubybunny.info/articles/connecting.html
I made the assumption that :logfile is deprecated and documented it as
such. However, since :logger is useful to me, I decided it must have
been accidentally omitted from the API docs and guide.
michaelklishin
added a commit
that referenced
this pull request
Dec 5, 2014
Document Session options for logging.
|
Feel free to submit a PR for the guides repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document Session#initialize options:
One of the guides mentions :logfile and :log_level, but not :logger
nor :logfile.
I made the assumption that :logfile is deprecated and documented it as
such. However, since :logger is useful to me, I decided it must have
been accidentally omitted from the API docs and guide.