Fix CA cert regexp #609
Merged
Fix CA cert regexp #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex `/^([a-z]:?)?\//i` introduced in 334e98c is intended to pick Windows file paths (`C:/whatever`). But `^` matcher stands for "start of line", which leads to false-positive matches when inline certificate has a char with slash at the begginning of a some line. Certs like this one ``` -----BEGIN CERTIFICATE----- whatever U/whatever whatever -----END CERTIFICATE----- ``` are treated as a file path. As result Bunny is unable to connect to the RMQ server with self signed certificate and prints an error: ``` OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=error: certificate verify failed (self signed certificate in certificate chain) ``` A regexp matcher `\A` stands for "Start of string" and resolves false-positive match.
michaelklishin
approved these changes
Apr 18, 2021
sharshenov
added a commit
to sharshenov/bunny
that referenced
this pull request
Apr 18, 2021
Hey @michaelklishin, I mixed up specs descriptions in ruby-amqp#609. Sorry, I discovered the mistake only after the PR is merged.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex
/^([a-z]:?)?\//iintroduced in 334e98c is intended to pick Windows file paths (C:/whatever).But
^matcher stands for "start of line", which leads to false-positive matches when inline certificate has a char with slash at the begginning of a some line.Certs like this one
are treated as a file path.
As result Bunny is unable to connect to the RMQ server with self signed certificate and prints an error:
A regexp matcher
\Astands for "Start of string" and resolves false-positive match.