fix: prevent race condition when manually closing channel #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, explicitly calling `Channel#close` might unregister the channel from the session before the AMQP Close message gets processed. Backtrace: ``` Dec 15 16:39:02 ruby[321979]: W, [2022-12-15T16:39:02.427534 #321979] WARN -- #<Bunny::Session:0x48648 app@localhost:5672, vhost=/, addresses=[localhost:5672]>: TCP connection failed, reconnecting in 5.0 seconds Dec 15 16:39:02 ruby[321979]: W, [2022-12-15T16:39:02.427582 #321979] WARN -- #<Bunny::Session:0x48648 app@localhost:5672, vhost=/, addresses=[localhost:5672]>: Will recover from a network failure (no retry limit)... Dec 15 16:39:02 ruby[321979]: #<Thread:0x00007f3c1ae18540 /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/reader_loop.rb:35 run> terminated with exception (report_on_exception is true): Dec 15 16:39:02 ruby[321979]: /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/session.rb:1031:in `block in unregister_channel': undefined method `number' for nil:NilClass (NoMethodError) Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/session.rb:1030:in `synchronize' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/session.rb:1030:in `unregister_channel' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/session.rb:675:in `ensure in handle_frame' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/session.rb:675:in `handle_frame' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/reader_loop.rb:92:in `run_once' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/reader_loop.rb:39:in `block in run_loop' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/reader_loop.rb:36:in `loop' Dec 15 16:39:02 ruby[321979]: from /opt/app/vendor/bundle/ruby/3.0.0/gems/bunny-2.19.0/lib/bunny/reader_loop.rb:36:in `run_loop' ```
|
Thank you! I will slightly alter the wording, merge and publish a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, explicitly calling
Channel#closemight unregister the channel from the session before the AMQP Close message gets processed.Backtrace: