Make output_format matching more robust. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue at ruby-av/paperclip-av-transcoder#3 is caused, at least on my system with Paperclip 4.2, by the format parameter of the form: ".FMT". This caused the case statement to not match any of the desired formats! It's likely that other paperclip version don't pass the dot before the format extension, but it seems likely that the behavior may differ depending on the version. This change looks for the end of the format string to match using a regex, and should now properly find the format, allowing thumbnails to be generated (as well as the proper switches for non image params)
|
Breaks the gem. https://travis-ci.org/ruby-av/av/builds/45563088 |
|
whoops. I'll look into that. thanks. |
It was failing because it was manually adding the output_type, while the Base#add_destination does it as well, causing the options, aac and experimental to be added twice. While this fixes the issue, I wonder if it might be better to make the option setting idempontent? Although with command- line switches, I suppose one never knows when repeated arguments are valid and necessary.
|
@owahab If fixed the failing spec. Please let me know what you think, thanks! |
|
Awesome, works. Thank you. |
owahab
added a commit
that referenced
this pull request
Jan 1, 2015
Make output_format matching more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue at ruby-av/paperclip-av-transcoder#3
is caused, at least on my system with Paperclip 4.2, by the format
parameter of the form: ".FMT". This caused the case statement to not
match any of the desired formats! It's likely that other paperclip
version don't pass the dot before the format extension, but it seems
likely that the behavior may differ depending on the version.
This change looks for the end of the format string to match using a
regex, and should now properly find the format, allowing thumbnails
to be generated (as well as the proper switches for non image params)