add url validation to commit model #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalithr95
force-pushed
the
url-validation
branch
from
c000995
to
a82e690
Compare
| @@ -25,4 +25,21 @@ class CommitTest < ActiveSupport::TestCase | |||
| commit = create(:commit, sha1: '1234567') | |||
| assert_includes commit.version, '12345' | |||
| end | |||
|
|
|||
| test "validates valid URL" do | |||
| valid_url = ['https://github.com/ruby-bench/ruby-bench-web/blob/master/app/models/commit.rb', | |||
There was a problem hiding this comment.
Nitpick here: I prefer
valid_url = [
'https://...',
'http://...'
]
😄
|
PR looks good to me :) 👍 |
lalithr95
force-pushed
the
url-validation
branch
from
a82e690
to
ced23a8
Compare
|
@tgxworld updated changes 😃 |
tgxworld
added a commit
that referenced
this pull request
Feb 21, 2016
add url validation to commit model
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL validation is done through URI regex and necessary tests are also listed