Bump to Rails 7.1.1 and Shakapacer 7.1.0 #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
reviewed
Oct 16, 2023
config/application.rb
Outdated
| # require "action_text/engine" | ||
| require "action_view/railtie" | ||
| require "action_cable/engine" | ||
| require "rails/test_unit/railtie" |
There was a problem hiding this comment.
这里别改，以后麻烦，我每次升级 Rails 都会做一次 rails app:update 对每个默认文件进行 Diff，多一个差异，以后多一个工作。我一般都尽量保持默认文件与默认的一致，除非是不得不改。
There was a problem hiding this comment.
这个主要是我不把action_text注释掉，会CI报错，除非按照 9e522f2 这样改。
huacnlee
reviewed
Oct 16, 2023
config/environments/development.rb
Outdated
| @@ -23,6 +23,7 @@ | |||
| config.action_controller.perform_caching = true | |||
| config.action_controller.enable_fragment_cache_logging = true | |||
|
|
|||
| config.cache_store = :memory_store | |||
huacnlee
reviewed
Oct 16, 2023
config/environments/test.rb
Outdated
| @@ -9,14 +9,13 @@ | |||
| # Settings specified here will take precedence over those in config/application.rb. | |||
|
|
|||
| # While tests run files are not watched, reloading is not necessary. | |||
| config.enable_reloading = true | |||
| config.enable_reloading = false | |||
There was a problem hiding this comment.
你这个是来自于 Rails 默认的配置吗？之前 Rails 7.1.0 有 CI 的错误，我改过一次，忘了
There was a problem hiding this comment.
你改的是这个：94e01e8#diff-77f322f5ab0c54b1f2793b339574333dc55889645d910a93ede0fd7aa13b217aL19 rails默认是false。
Eric-Guo
changed the title
Eric-Guo
commented
Oct 16, 2023
config/environments/development.rb
Outdated
| @@ -73,5 +74,5 @@ | |||
| config.active_job.queue_adapter = :inline | |||
|
|
|||
| # Raise error when a before_action's only/except options reference missing actions | |||
| config.action_controller.raise_on_missing_callback_actions = true | |||
| config.action_controller.raise_on_missing_callback_actions = false | |||
There was a problem hiding this comment.
这个不是默认的，默认是true（对于Rails 7.1），但是目前给true会导致CI报错，但是如果不加这行，默认是false
|
你看我前几个 commit，不会保错的，你没搞对
Eric Guo ***@***.***>于2023年10月16日 周一上午11:02写道：
… ***@***.**** commented on this pull request.
------------------------------
In config/application.rb
<#1391 (comment)>:
> @@ -1,6 +1,18 @@
require_relative "boot"
-require "rails/all"
+require "rails"
+# Pick the frameworks you want:
+require "active_model/railtie"
+require "active_job/railtie"
+require "active_record/railtie"
+require "active_storage/engine"
+require "action_controller/railtie"
+require "action_mailer/railtie"
+# require "action_mailbox/engine"
+# require "action_text/engine"
+require "action_view/railtie"
+require "action_cable/engine"
+require "rails/test_unit/railtie"
这个主要是我不把action_text注释掉，会CI报错，除非按照 9e522f2
<9e522f2>
这样改。
—
Reply to this email directly, view it on GitHub
<#1391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABLDUQDTSRRSUOOW6T6B3X7SPUZANCNFSM6AAAAAA6AZFIKM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
你看我最新的提交，你不需要改 Rails 的部分，目前已经是 Rails 7.1.1 测试也是对的。你只需改 Shakapacer 部分即可。 |
Eric-Guo
force-pushed
the
rails_shakapacker_71
branch
from
f04ecc3
to
364a4f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在天华的BBS上开始跑了，目测没啥Bug。