Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rails 5 #555

Merged
merged 19 commits into from
Feb 2, 2016
Merged

Upgrade Rails 5 #555

merged 19 commits into from
Feb 2, 2016

Conversation

huacnlee
Copy link
Member

TODO:

  • 理清 Gem 以支持 Rails
  • 修复升级带出的程序代码问题
  • Sidekiq 管理后台需要 Sinatra, 但目前还不支持 Rails 5
  • ActionCable 代替 MessageBus
  • rspec-rails 需要修正 Helper 里面 xxx_path 这样的 url_helpers, 相关 Issue: rspec-rails/rspec-rails#1525
  • cancancan 里面调用了过期的逻辑,需要升级,但目前不影响使用,只是有 Warning

@huacnlee
Copy link
Member Author

还有几个测试错误是 rspec-rails 的问题

@songjiayang
Copy link
Contributor

👍 @huacnlee 好奇,我看到有些配置文件注释修改,这个是通过 Rails 5 升级自动做到的,还是你手动修改的呢?

@huacnlee
Copy link
Member Author

@songjiayang rake rails:update 会有 Diff,然后手工修改

@songjiayang
Copy link
Contributor

对,想起了。

huacnlee added a commit that referenced this pull request Feb 2, 2016
@huacnlee huacnlee merged commit 647f09a into master Feb 2, 2016
@huacnlee huacnlee deleted the upgrade/rails-5 branch February 2, 2016 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants