Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing #484

Closed
balasankarc opened this issue Dec 11, 2015 · 7 comments
Closed

Test failing #484

balasankarc opened this issue Dec 11, 2015 · 7 comments

Comments

@balasankarc
Copy link

Hi,
I am packaging concurrent-ruby for Debian as part of GitLab packaging and am stuck with a weird test failure. All the tests run fine except one. The log can be seen here - http://paste.debian.net/343198/

Please help me fix it.

@jdantonio
Copy link
Member

That test is not part of the core concurrent-ruby gem, it's part of the Edge gem and can safely be ignored. The code under test won't be packaged with concurrent-ruby.

We build three gems out of this repository:

  • concurrent-ruby is the core gem
  • concurrent-ruby-ext contains optional C extensions
  • concurrent-ruby-edge contains experimental features not necessarily ready of inclusion in the core gem

The code being tested by the failing test is part of concurrent-ruby-edge. If you package just the core concurrent-ruby gem you won't have that code.

I'm out of town for business today but will be home soon. Once I return home I'll go through our tests and make sure that all tests not in the core gem are tagged so that they can be easily excluded from CI runs.

To see what files are in which gem please reference our file map.

@balasankarc
Copy link
Author

Ok. Thanks. I will skip it in the package for now.

@balasankarc
Copy link
Author

@jdantonio Hi, when you get time, can you please tag which all tests are part of the core gem?

@jdantonio
Copy link
Member

Tomorrow is Christmas Eve so I won't be able to get to this for a few days. I hope to be able to do this next week.

@balasankarc
Copy link
Author

That is fine. For now I will simply disable the failing tests. Happy holidays. :)

@jdantonio
Copy link
Member

Merged in PR #491.

@balasankarc
Copy link
Author

Thanks @jdantonio . This is a great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants