-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow require 'concurrent' on windows #971
Comments
Can you profile it for me? I'm sorry I'm not going to be able to help with anything Windows-specific - I just don't know anything about it. |
It is faster today, probably because of a cache, I've also checked the code and could only find one windows specific part, which doesn't seem to be an issue. require 'ruby-prof'
result = RubyProf.profile do
require 'concurrent'
end
printer = RubyProf::FlatPrinter.new(result)
printer.print(File.open("ruby_prof_example_api1_profile.txt", "w+"))
|
The top two make it seem like an IO issue? Are you one some kind of strange machine, or a virtualised machine? This isn't likely to be a Concurrent Ruby issue, so I'm closing unless there is evidence otherwise. I'm happy to keep engaging with you here to try to help as best I can though. |
Hi!
So I'm on the hunt for the reason why my app needs seconds to start instead of miliseconds. I'm using TZInfo in my app which depends on concurrent-ruby. I'm not sure if anything can be done about it, as the issue might lie with ruby on windows but maybe it can be improved? I assume this also affects rails on windows startup.
Windows benchmark on an intel core i9 laptop:
0.047000 0.734000 0.781000 ( 2.150554)
Linux benchmark on a simple cloud VPS:
0.043045 0.003789 0.046834 ( 0.050957)
2.10 seconds vs 0.05 seconds
Thanks for your hard work!
The text was updated successfully, but these errors were encountered: