Avoid Ruby warning by removing an "interesting" whitespace #36
Conversation
- warning emitted: parentheses after method name is interpreted as an argument list, not a decomposed argument
olleolleolle
changed the title
|
I have no idea why such an innocuous change broke the build. Rebuilding... |
|
Thank you for responding so quickly! |
|
@jdantonio rbx-2 no longer exists as a target to build to. it's called something else. Perhaps rbx-3? Perhaps I can see the CI matrix is a little outdated. There are a few newer versions out. |
- number taken from https://rubinius.com/install/
- in a bid to get rbx-3.84 working
|
@jdantonio So, I have now reinstated Am I allowed to move rbx to Example failing build of |
|
@olleolleolle Absolutely! The rbx community has gotten upset with me in the past for putting it in allowed failures, but there are pragmatic realities we need to consider. Please move it. And thank you very much for all your hard work! Would you like commit rights to this repo? I'm not heavily involved in this project any more (sadly, I am not working with Ruby in my current job 😞) so I'd love any assistance you are interested in giving. |
|
@jdantonio For this project, I'm more of an arm-chair patcher than an on-the-frontline maintainer. I'm comfortable with a slower rate of merges than "me pushing a big green button with no one knowing". |
|
@jdantonio I'm right now adding an RSpec 3.6 update to the Gemfile, to see if that can placate |
|
@jdantonio (About rbx) That made the test suite pass! It didn't, however, make the job end, which will make it time out, I believe. |
|
@jdantonio I will now update |
|
@jdantonio There! A green build! |
.travis.yml
Outdated
| before_install: | ||
| - gem update --system | ||
| - gem install bundler | ||
| after_success: |
There was a problem hiding this comment.
I have a feeling this is not needed!
There was a problem hiding this comment.
Sent a commit to skip that step.
|
@jdantonio How do you like it, now? |
|
@olleolleolle Thanks! |
|
I appreciate your help. |
This PR wants to fix a Ruby warning emitted:
This appears when running Sinatra's test suite.
https://api.travis-ci.org/jobs/268657054/log.txt?deansi=true
In order to get a green build for this, I went down the rabbit hole and tried to make it green.