New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests fixes #131
tests fixes #131
Conversation
be2a192
to
7d56412
Compare
@@ -1,3 +1,9 @@ | |||
if RUBY_VERSION < '2.0' || defined?(JRUBY_VERSION) | |||
require 'ruby-debug-base' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19x?
Regarding the last commit: so, why have these last tests been failing? It's very suspicious to me that it's only mac and ruby 2.5 affected |
test-base/test_base.rb
Outdated
@@ -220,7 +220,7 @@ def run_to_line(line_number) | |||
|
|||
def assert_suspension(exp_file, exp_line, exp_frames, exp_thread_id=1) | |||
suspension = read_suspension | |||
assert_equal(exp_file, suspension.file) | |||
assert_true(File.identical?(exp_file, suspension.file)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed after the last commit (using realpath)?
9ead632
to
91f92e2
Compare
(cherry picked from commit ac9e8b1) (cherry picked from commit a492b11)
Sometimes it is evaluating before the ruby-debug-ide.rb, from where it normally requires
This fixes skipped stepping on oneliner blocks
1e08402
to
b916561
Compare
The changes in case of
debase
front end are related to differences in the logging of control frames. For 'debase' case there are two debugger frames (rdebug-ide and ruby-debug-ide). As a consequence, it is necessary to increase the number of frames by 2 in all the corresponding asserts.test/ruby-debug/xml_printer_test.rb:69 need to be investigated.
(cherry picked from commit ac9e8b1)
(cherry picked from commit a492b11)