Fixed the 'already initialized constant TAG' warning by converting to class level methods #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the gem! I noticed some warnings about redeclared constants, so I switched them to static methods.
BEFORE CHANGE:
Andrews-MacBook-Pro:docx aforward$ bundle exec irb
irb(main):001:0> require "docx"; Docx::Document
/Users/aforward/tp/projects/docx/lib/docx/elements/bookmark.rb:9: warning: already initialized constant TAG
/Users/aforward/tp/projects/docx/lib/docx/elements/text.rb:6: warning: already initialized constant TAG
/Users/aforward/tp/projects/docx/lib/docx/containers/text_run.rb:16: warning: already initialized constant TAG
/Users/aforward/tp/projects/docx/lib/docx/containers/paragraph.rb:11: warning: already initialized constant TAG
=> Docx::Document
AFTER CHANGE:
Andrews-MacBook-Pro:docx aforward$ bundle exec irb
irb(main):001:0> require "docx"; Docx::Document
=> Docx::Document