Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxgettext - added --gnu-compatibility option #18

Closed
wants to merge 1 commit into from
Closed

rxgettext - added --gnu-compatibility option #18

wants to merge 1 commit into from

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Aug 6, 2013

to produce a GNU gettext compatible PO file (no double escaped new line charaters, removed Plural-Forms header tag)

Small implementation change: subclass RubyPOEntry from POEntry to reuse the format_message method and to avoid aliasing initialization method.

@lslezak
Copy link
Contributor Author

lslezak commented Aug 6, 2013

BTW there is a small overlap with #16.

@lslezak
Copy link
Contributor Author

lslezak commented Aug 6, 2013

The reason for this change is that our translators already use GNU tools and we need to produce backward compatible POT files after switching to Ruby. I added a new command line option so it does not break the current behavior for rxgettext and rmsgfmt tools.

@375gnu
Copy link
Contributor

375gnu commented Aug 27, 2013

lslezak, is this a good idea to remove Plural-Forms? I think today 99% of po files are made using gnu gettext and they all have Plural-Forms.

to produce a GNU gettext compatible PO file
(no double escaped new line charaters, removed Plural-Forms header tag)
@lslezak
Copy link
Contributor Author

lslezak commented Aug 28, 2013

I have added it back, we merge POT files created by both rxgettext and GNU gettext and during merge msgcat complained about invalid nplurals value.

I have fixed our merging script and reverted the removal.

@kou kou closed this in de66713 Aug 30, 2013
@kou
Copy link
Member

kou commented Aug 30, 2013

Thanks!
I've fixed it in master.

Sorry for my late fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants